Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

extensions/browser/api/web_request/upload_data_presenter_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
+#include <utility>
+
 #include "base/values.h"
 #include "extensions/browser/api/web_request/upload_data_presenter.h"
 #include "extensions/browser/api/web_request/web_request_api_constants.h"
 #include "net/base/upload_bytes_element_reader.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace keys = extension_web_request_api_constants;
 
 namespace extensions {
 
@@ skipping 33 matching lines @@
 
   // Expected output.
   std::unique_ptr<base::BinaryValue> expected_a(
       base::BinaryValue::CreateWithCopiedBuffer(block1, block1_size));
   ASSERT_TRUE(expected_a.get() != NULL);
   std::unique_ptr<base::StringValue> expected_b(
       new base::StringValue(kFilename));
   ASSERT_TRUE(expected_b.get() != NULL);
   std::unique_ptr<base::BinaryValue> expected_c(
       base::BinaryValue::CreateWithCopiedBuffer(block2, block2_size));
   ASSERT_TRUE(expected_c.get() != NULL);

[dcheng, 2016/06/15 08:34:03]

These asserts don't really seem useful but meh. If you feel strongly, I can
remove these and inline the creation into the AppendKeyValuePair calls below.

 
   base::ListValue expected_list;
-  subtle::AppendKeyValuePair(
-      keys::kRequestBodyRawBytesKey, expected_a.release(), &expected_list);
-  subtle::AppendKeyValuePair(
-      keys::kRequestBodyRawFileKey, expected_b.release(), &expected_list);
-  subtle::AppendKeyValuePair(
-      keys::kRequestBodyRawBytesKey, expected_c.release(), &expected_list);
+  subtle::AppendKeyValuePair(keys::kRequestBodyRawBytesKey,
+                             std::move(expected_a), &expected_list);
+  subtle::AppendKeyValuePair(keys::kRequestBodyRawFileKey,
+                             std::move(expected_b), &expected_list);
+  subtle::AppendKeyValuePair(keys::kRequestBodyRawBytesKey,
+                             std::move(expected_c), &expected_list);
 
   // Real output.
   RawDataPresenter raw_presenter;
   raw_presenter.FeedNextBytes(block1, block1_size);
   raw_presenter.FeedNextFile(kFilename);
   raw_presenter.FeedNextBytes(block2, block2_size);
   EXPECT_TRUE(raw_presenter.Succeeded());
   std::unique_ptr<base::Value> result = raw_presenter.Result();
   ASSERT_TRUE(result.get() != NULL);
 
   EXPECT_TRUE(result->Equals(&expected_list));
 }
 
 }  // namespace extensions