Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

extensions/browser/api/web_request/upload_data_presenter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/web_request/upload_data_presenter.h"
 
 #include <utility>
 
 #include "base/files/file_path.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/string_util.h"
 #include "base/values.h"
 #include "extensions/browser/api/web_request/form_data_parser.h"
 #include "extensions/browser/api/web_request/web_request_api_constants.h"
 #include "net/base/upload_bytes_element_reader.h"
 #include "net/base/upload_file_element_reader.h"
 #include "net/url_request/url_request.h"
 
 using base::BinaryValue;
 using base::DictionaryValue;
@@ skipping 17 matching lines @@
   return list;
 }
 
 }  // namespace
 
 namespace extensions {
 
 namespace subtle {
 
 void AppendKeyValuePair(const char* key,
-                        base::Value* value,
+                        std::unique_ptr<base::Value> value,
                         base::ListValue* list) {
   std::unique_ptr<base::DictionaryValue> dictionary(new base::DictionaryValue);
-  dictionary->SetWithoutPathExpansion(key, value);
+  dictionary->SetWithoutPathExpansion(key, std::move(value));
   list->Append(std::move(dictionary));
 }
 
 }  // namespace subtle
 
 UploadDataPresenter::~UploadDataPresenter() {}
 
 RawDataPresenter::RawDataPresenter()
   : success_(true),
     list_(new base::ListValue) {
@@ skipping 29 matching lines @@
 
 void RawDataPresenter::FeedNextBytes(const char* bytes, size_t size) {
   subtle::AppendKeyValuePair(keys::kRequestBodyRawBytesKey,
                              BinaryValue::CreateWithCopiedBuffer(bytes, size),
                              list_.get());
 }
 
 void RawDataPresenter::FeedNextFile(const std::string& filename) {
   // Insert the file path instead of the contents, which may be too large.
   subtle::AppendKeyValuePair(keys::kRequestBodyRawFileKey,
-                             new base::StringValue(filename),
+                             base::MakeUnique<base::StringValue>(filename),
                              list_.get());
 }
 
 ParsedDataPresenter::ParsedDataPresenter(const net::URLRequest& request)
   : parser_(FormDataParser::Create(request)),
     success_(parser_.get() != NULL),
     dictionary_(success_ ? new base::DictionaryValue() : NULL) {
 }
 
 ParsedDataPresenter::~ParsedDataPresenter() {}
@@ skipping 45 matching lines @@
     dictionary_(success_ ? new base::DictionaryValue() : NULL) {
 }
 
 void ParsedDataPresenter::Abort() {
   success_ = false;
   dictionary_.reset();
   parser_.reset();
 }
 
 }  // namespace extensions