extensions/browser/api/web_request/upload_data_presenter_unittest.cc - Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/upload_data_presenter_unittest.cc

Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android and CrOS Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/pepper/pepper_socket_utils.cc ('K') | « extensions/browser/api/web_request/upload_data_presenter.cc ('k') | ipc/ipc_message_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/web_request/upload_data_presenter_unittest.cc

diff --git a/extensions/browser/api/web_request/upload_data_presenter_unittest.cc b/extensions/browser/api/web_request/upload_data_presenter_unittest.cc

index ff27ebcc6f744fc830faf765ccf4cba57a066300..90e84cd1f46714ebef781decef3c3ebaf74c4ae0 100644

--- a/extensions/browser/api/web_request/upload_data_presenter_unittest.cc

+++ b/extensions/browser/api/web_request/upload_data_presenter_unittest.cc

@@ -4,6 +4,8 @@

#include <stddef.h>

+#include <utility>

#include "base/values.h"

#include "extensions/browser/api/web_request/upload_data_presenter.h"

#include "extensions/browser/api/web_request/web_request_api_constants.h"

@@ -60,12 +62,12 @@ TEST(WebRequestUploadDataPresenterTest, RawData) {

ASSERT_TRUE(expected_c.get() != NULL);

dcheng 2016/06/15 08:34:03 These asserts don't really seem useful but meh. If

base::ListValue expected_list;

- subtle::AppendKeyValuePair(

- keys::kRequestBodyRawBytesKey, expected_a.release(), &expected_list);

- subtle::AppendKeyValuePair(

- keys::kRequestBodyRawFileKey, expected_b.release(), &expected_list);

- subtle::AppendKeyValuePair(

- keys::kRequestBodyRawBytesKey, expected_c.release(), &expected_list);

+ subtle::AppendKeyValuePair(keys::kRequestBodyRawBytesKey,

+ std::move(expected_a), &expected_list);

+ subtle::AppendKeyValuePair(keys::kRequestBodyRawFileKey,

+ std::move(expected_b), &expected_list);

+ subtle::AppendKeyValuePair(keys::kRequestBodyRawBytesKey,

+ std::move(expected_c), &expected_list);

// Real output.

RawDataPresenter raw_presenter;