extensions/browser/api/web_request/upload_data_presenter.h - Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/upload_data_presenter.h

Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android and CrOS Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/pepper/pepper_socket_utils.cc ('K') | « extensions/browser/api/hid/hid_api.cc ('k') | extensions/browser/api/web_request/upload_data_presenter.cc » ('j') | extensions/browser/api/web_request/upload_data_presenter_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/web_request/upload_data_presenter.h

diff --git a/extensions/browser/api/web_request/upload_data_presenter.h b/extensions/browser/api/web_request/upload_data_presenter.h

index 05630f3dcbc4be912b01f673f13ac1acb45b7326..fc2f5d79c590ba0717be20d75c84131fc9c78735 100644

--- a/extensions/browser/api/web_request/upload_data_presenter.h

+++ b/extensions/browser/api/web_request/upload_data_presenter.h

@@ -35,10 +35,9 @@ namespace subtle {

// Helpers shared with unit-tests.

-// Appends a dictionary {'key': 'value'} to |list|. |list| becomes the owner of

-// |value|.

+// Appends a dictionary {'key': 'value'} to |list|.

void AppendKeyValuePair(const char* key,

- base::Value* value,

+ std::unique_ptr<base::Value> value,

base::ListValue* list);

} // namespace subtle