extensions/browser/api/cast_channel/cast_message_util.cc - Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_message_util.cc

Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android and CrOS Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/pepper/pepper_socket_utils.cc ('K') | « content/common/android/gin_java_bridge_value.cc ('k') | extensions/browser/api/hid/hid_api.cc » ('j') | extensions/browser/api/web_request/upload_data_presenter_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/cast_channel/cast_message_util.cc

diff --git a/extensions/browser/api/cast_channel/cast_message_util.cc b/extensions/browser/api/cast_channel/cast_message_util.cc

index f81b20aa17cef57f445093e2703541fcb4e91e4d..84af993e4bc6a236937f10542e556c0435baa71f 100644

--- a/extensions/browser/api/cast_channel/cast_message_util.cc

+++ b/extensions/browser/api/cast_channel/cast_message_util.cc

@@ -89,9 +89,9 @@ bool CastMessageToMessageInfo(const CastMessage& message_proto,

break;

case CastMessage_PayloadType_BINARY:

if (message_proto.has_payload_binary())

- value.reset(base::BinaryValue::CreateWithCopiedBuffer(

- message_proto.payload_binary().data(),

- message_proto.payload_binary().size()));

+ value = base::BinaryValue::CreateWithCopiedBuffer(

+ message_proto.payload_binary().data(),

+ message_proto.payload_binary().size());

break;

default:

// Unknown payload type. value will remain unset.