content/child/v8_value_converter_impl.cc - Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/v8_value_converter_impl.cc

Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android and CrOS Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/pepper/pepper_socket_utils.cc ('K') | « content/browser/renderer_host/pepper/pepper_socket_utils.cc ('k') | content/common/android/gin_java_bridge_value.h » ('j') | extensions/browser/api/web_request/upload_data_presenter_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/v8_value_converter_impl.cc

diff --git a/content/child/v8_value_converter_impl.cc b/content/child/v8_value_converter_impl.cc

index d0e084cf8e8a050283d94a710d9e2dd5266fa7bc..89378a8cb9dcfd1396f11f938e61ab7bd9c76d4d 100644

--- a/content/child/v8_value_converter_impl.cc

+++ b/content/child/v8_value_converter_impl.cc

@@ -515,8 +515,7 @@ std::unique_ptr<base::Value> V8ValueConverterImpl::FromV8ArrayBuffer(

}

if (data)

- return base::WrapUnique(

- base::BinaryValue::CreateWithCopiedBuffer(data, length));

+ return base::BinaryValue::CreateWithCopiedBuffer(data, length);

else

return nullptr;

}