Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: ipc/ipc_message_utils.cc

Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android and CrOS Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_message_utils.cc
diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc
index 3bdf20733c7e5d23c3f468912906eb2943306b75..302778e495eccab005e2ec54e2c5a258b25f1f17 100644
--- a/ipc/ipc_message_utils.cc
+++ b/ipc/ipc_message_utils.cc
@@ -298,7 +298,9 @@ bool ReadValue(const base::Pickle* m,
int length;
if (!iter->ReadData(&data, &length))
return false;
- *value = base::BinaryValue::CreateWithCopiedBuffer(data, length);
+ std::unique_ptr<base::BinaryValue> val =
+ base::BinaryValue::CreateWithCopiedBuffer(data, length);
+ *value = val.release();
break;
}
case base::Value::TYPE_DICTIONARY: {

Powered by Google App Engine
This is Rietveld 408576698