Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ppapi/shared_impl/private/ppb_x509_certificate_private_shared.h

Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android and CrOS Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« extensions/browser/api/web_request/upload_data_presenter_unittest.cc ('K') | « mojo/common/common_custom_types_unittest.cc ('k') | ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/private/ppb_x509_certificate_private_shared.h
diff --git a/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.h b/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.h
index b68e091b18a5843619e7b7d1770f7879862a0f58..83122f6d3b92ddbad6c6521a7d6154ec91a21a23 100644
--- a/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.h
+++ b/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.h
@@ -29,7 +29,8 @@ class PPAPI_SHARED_EXPORT PPB_X509Certificate_Fields {
PPB_X509Certificate_Fields(const PPB_X509Certificate_Fields& fields);
// Takes ownership of |value|.
- void SetField(PP_X509Certificate_Private_Field field, base::Value* value);
+ void SetField(PP_X509Certificate_Private_Field field,
+ std::unique_ptr<base::Value> value);
PP_Var GetFieldAsPPVar(PP_X509Certificate_Private_Field field) const;
private:
« extensions/browser/api/web_request/upload_data_presenter_unittest.cc ('K') | « mojo/common/common_custom_types_unittest.cc ('k') | ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698