Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Unified Diff: extensions/browser/api/hid/hid_api.cc

Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android and CrOS Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/hid/hid_api.cc
diff --git a/extensions/browser/api/hid/hid_api.cc b/extensions/browser/api/hid/hid_api.cc
index b03ae8baaa7b704bd1e59158372d69b6c36e2dd3..c93f6e9c6ef25bf7ac99f35dd268e8557c30ae3c 100644
--- a/extensions/browser/api/hid/hid_api.cc
+++ b/extensions/browser/api/hid/hid_api.cc
@@ -290,10 +290,9 @@ void HidReceiveFunction::OnFinished(bool success,
DCHECK_GE(size, 1u);
int report_id = reinterpret_cast<uint8_t*>(buffer->data())[0];
- Respond(
- TwoArguments(base::MakeUnique<base::FundamentalValue>(report_id),
- base::WrapUnique(base::BinaryValue::CreateWithCopiedBuffer(
- buffer->data() + 1, size - 1))));
+ Respond(TwoArguments(base::MakeUnique<base::FundamentalValue>(report_id),
+ base::BinaryValue::CreateWithCopiedBuffer(
+ buffer->data() + 1, size - 1)));
} else {
Respond(Error(kErrorTransfer));
}
@@ -350,8 +349,8 @@ void HidReceiveFeatureReportFunction::OnFinished(
scoped_refptr<net::IOBuffer> buffer,
size_t size) {
if (success) {
- Respond(OneArgument(base::WrapUnique(
- base::BinaryValue::CreateWithCopiedBuffer(buffer->data(), size))));
+ Respond(OneArgument(
+ base::BinaryValue::CreateWithCopiedBuffer(buffer->data(), size)));
} else {
Respond(Error(kErrorTransfer));
}

Powered by Google App Engine
This is Rietveld 408576698