chrome/browser/extensions/api/web_request/web_request_api_unittest.cc - Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android and CrOS Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/audio_modem/audio_modem_api_unittest.cc ('K') | « chrome/browser/extensions/api/idltest/idltest_api.cc ('k') | content/browser/renderer_host/pepper/pepper_socket_utils.cc » ('j') | content/browser/renderer_host/pepper/pepper_socket_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

index edeb30682ec84b87c6aa76073603c7104419cfaf..07a88e4723b4ba43509c761dedf4d3186281ef56 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

@@ -600,8 +600,7 @@ TEST_F(ExtensionWebRequestTest, AccessRequestBodyData) {

&raw);

extensions::subtle::AppendKeyValuePair(

keys::kRequestBodyRawFileKey,

- new base::StringValue(std::string()),

- &raw);

+ base::MakeUnique<base::StringValue>(std::string()), &raw);

extensions::subtle::AppendKeyValuePair(

keys::kRequestBodyRawBytesKey,

BinaryValue::CreateWithCopiedBuffer(kPlainBlock2, kPlainBlock2Length),