mojo/common/common_custom_types_unittest.cc - Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/common/common_custom_types_unittest.cc

Issue 2065793002: Return a unique_ptr from BinaryValue::CreateWithCopiedBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android and CrOS Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/web_request/upload_data_presenter_unittest.cc ('K') | « ipc/ipc_message_utils.cc ('k') | ppapi/shared_impl/private/ppb_x509_certificate_private_shared.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/common/common_custom_types_unittest.cc

diff --git a/mojo/common/common_custom_types_unittest.cc b/mojo/common/common_custom_types_unittest.cc

index d0e115b50ee1d649a640dfad08a02cabf288b7db..370c2d451689973e20a773a74a69622c76b0c98b 100644

--- a/mojo/common/common_custom_types_unittest.cc

+++ b/mojo/common/common_custom_types_unittest.cc

@@ -164,9 +164,7 @@ TEST_F(CommonCustomTypesTest, Value) {

dict.SetString("string", "some string");

dict.SetBoolean("nested.bool", true);

dict.SetInteger("nested.int", 9);

- dict.Set(

- "some_binary",

- base::WrapUnique(base::BinaryValue::CreateWithCopiedBuffer("mojo", 4)));

+ dict.Set("some_binary", base::BinaryValue::CreateWithCopiedBuffer("mojo", 4));

{

std::unique_ptr<base::ListValue> dict_list(new base::ListValue());

dict_list->AppendString("string");

@@ -187,8 +185,7 @@ TEST_F(CommonCustomTypesTest, Value) {

list.AppendString("string");

list.AppendDouble(42.1);

list.AppendBoolean(true);

- list.Append(

- base::WrapUnique(base::BinaryValue::CreateWithCopiedBuffer("mojo", 4)));

+ list.Append(base::BinaryValue::CreateWithCopiedBuffer("mojo", 4));

{

std::unique_ptr<base::DictionaryValue> list_dict(

new base::DictionaryValue());