Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
hans, brettw
CC:
chromium-reviews, sadrul, blink-reviews-platform-graphics_chromium.org, achuith+watch_chromium.org, eric.carlson_apple.com, arv+watch_chromium.org, krit, yunlian, blink-reviews-html_chromium.org, dglazkov+blink, kalyank, ajuma+watch_chromium.org, jbudorick+watch_chromium.org, mlamouri+watch-content_chromium.org, derat+watch_chromium.org, loading-reviews_chromium.org, vcarbune.chromium, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, tfarina, f(malita), bruening+watch_chromium.org, fs, glider+clang_chromium.org, noyau+watch_chromium.org, native-client-reviews_googlegroups.com, rwlbuis, drott+blinkwatch_chromium.org, aboxhall, samuong+watch_chromium.org, szager+layoutwatch_chromium.org, jam, Rik, blink-reviews, chromium-apps-reviews_chromium.org, nessy, nhiroki, mkwst+moarreviews-shell_chromium.org, Nate Chapin, mkwst+watchlist-passwords_chromium.org, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, ukai+watch_chromium.org, dtseng+watch_chromium.org, binji+watch_chromium.org, dshwang, dmazzoni+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, dzhioev+watch_chromium.org, Justin Novosad, je_julie, darin-cc_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, dmikurube+clang_chromium.org, zoltan1, blink-reviews-layout_chromium.org, jbroman, oshima+watch_chromium.org, piman+watch_chromium.org, sync-reviews_chromium.org, Dirk Pranke, tyoshino+watch_chromium.org, leviw+renderwatch, Stephen Chennney, glider+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org, tzik, posciak+watch_chromium.org, nektar+watch_chromium.org, eae+blinkwatch, Nico, eugenis+clang_chromium.org, Sam Clegg, cbentzel+watch_chromium.org, pdr+graphicswatchlist_chromium.org, aboxhall+watch_chromium.org, chromoting-reviews_chromium.org, gavinp+loader_chromium.org, mikecase+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, Peter Beverloo, Reid Kleckner, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, dmazzoni, mcasas+watch+vc_chromium.org, gcasto+watchlist_chromium.org, cc-bugs_chromium.org, gasubic, nektarios, mkwst+moarreviews-renderer_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

"up-to-date" should only use hyphens when used as compound modifier of a noun See bug, apparently it's "an up-to-date thing" but "thing is up to date". The bug is only about grd files, but I went through `git grep -l up-to-date` while I was at it. BUG=344535 TBR=IPC owner CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.blink:linux_blink_rel Committed: https://crrev.com/3e861deabe8e47db274ed779acc1a3b80837e16d Cr-Commit-Position: refs/heads/master@{#399698}

Patch Set 1 #

Patch Set 2 : nobrotli #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -113 lines) Patch
M .gn View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M build/android/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java View 1 chunk +1 line, -1 line 0 comments Download
M build/install-build-deps.sh View 2 chunks +2 lines, -2 lines 0 comments Download
M build/linux/install-chromeos-fonts.py View 1 chunk +1 line, -1 line 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/element_animations.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/property_tree_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chromium_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/settings_chromium_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/settings_google_chrome_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/settings_strings.grdp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/enterprise_install_attributes.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/editable_text.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/plugin_metadata/plugins_win.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/extensions/extension_action_view_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/all_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/caching_file_system.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/new_github_file_system.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/extensions_index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/run_buildbot_steps.py View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/chromeos/directory_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/chromeos/file_system/search_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/chromeos/sync_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/file_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/history_database.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/omnibox/browser/omnibox_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/policy_header_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/search_provider_logos/logo_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/signin_metrics.h View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/action_update_check.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/browser/visitedlink_master.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/all_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/plugin_list.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/plugin_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_deliverer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M docs/clang.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/linux_chromium_arm.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/linux_debugging.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/linux_faster_builds.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/tpm_quick_ref.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/windows_build_instructions.md View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/sdk_tools/command/list.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/sdk_tools/command/update.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/tests/sdktools_commands_test.py View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/sdk/release-notes.rst View 1 chunk +1 line, -1 line 0 comments Download
M pdf/paint_aggregator.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/utility/graphics/paint_aggregator.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/normalizing_input_filter_cros.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/mac/me2me_preference_pane.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/bounds-calc.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutCounter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/boringssl/roll_boringssl.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/docs/reference.md View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/ninja_action_target_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_binary_target_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/variables.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/valgrind/valgrind_test.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/render_text.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_bindings.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/touch_handler.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (19 generated)
Nico
4 years, 6 months ago (2016-06-13 11:22:29 UTC) #8
hans
From the description: > "up-to-date" should only use hyphens when used as compound modifier as ...
4 years, 6 months ago (2016-06-13 16:13:59 UTC) #9
brettw
rs lgtm
4 years, 6 months ago (2016-06-13 19:03:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059143002/20001
4 years, 6 months ago (2016-06-13 19:14:38 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/199798)
4 years, 6 months ago (2016-06-13 19:42:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059143002/20001
4 years, 6 months ago (2016-06-13 19:59:34 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/238187)
4 years, 6 months ago (2016-06-13 21:12:34 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059143002/20001
4 years, 6 months ago (2016-06-13 21:14:33 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/199923)
4 years, 6 months ago (2016-06-13 21:25:54 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059143002/40001
4 years, 6 months ago (2016-06-14 12:16:36 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-14 14:24:24 UTC) #29
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 14:24:38 UTC) #30
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 14:25:47 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3e861deabe8e47db274ed779acc1a3b80837e16d
Cr-Commit-Position: refs/heads/master@{#399698}

Powered by Google App Engine
This is Rietveld 408576698