.gn - Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: .gn

Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: .gn

diff --git a/.gn b/.gn

index f17971148c7e6f01861d6b5d6d19b9bdbfccbc04..3bd6bc4453bf327f7e904e420b6b2c1ea53e4b89 100644

--- a/.gn

+++ b/.gn

@@ -215,7 +215,7 @@ check_targets = [

# up a directory. The author notices that the script isn't re-run when the

# directory is updated, so adds a glob so all the files are listed as

# inputs. This seems to work great... until a file is deleted. When a

-# file is deleted, all the inputs the glob lists will still be up-to-date

+# file is deleted, all the inputs the glob lists will still be up to date

# and no command-lines will have been changed. The action will not be

# re-run and the build will be broken. It is possible to get this correct

# using glob, and it's possible to mess it up without glob, but globs make

« no previous file with comments | « no previous file | ash/system/chromeos/power/tray_power.cc » ('j') | no next file with comments »