third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp - Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutCounter.h ('k') | third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

index bb3cc3f80f4304244cbad146151cff70c69bf2ee..7731d3cd45876fd98dfce9b163df1b9a6a62a3e1 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

@@ -1197,7 +1197,7 @@ bool LayoutFlexibleBox::computeNextFlexLine(OrderedFlexItemList& orderedChildren

// If this condition is true, then computeMainAxisExtentForChild will call child.intrinsicContentLogicalHeight()

// and child.scrollbarLogicalHeight(), so if the child has intrinsic min/max/preferred size,

- // run layout on it now to make sure its logical height and scroll bars are up-to-date.

+ // run layout on it now to make sure its logical height and scroll bars are up to date.

if (childHasIntrinsicMainAxisSize(*child) && child->needsLayout()) {

child->clearOverrideSize();

child->layoutIfNeeded();