tools/gn/ninja_action_target_writer.cc - Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_action_target_writer.cc

Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_action_target_writer.cc

diff --git a/tools/gn/ninja_action_target_writer.cc b/tools/gn/ninja_action_target_writer.cc

index aed8ffbc864acebd33ffbd9dd83c66a2e21b9a23..17436323a92d25680c7160a4f96073a6c1e9ec88 100644

--- a/tools/gn/ninja_action_target_writer.cc

+++ b/tools/gn/ninja_action_target_writer.cc

@@ -166,7 +166,7 @@ void NinjaActionTargetWriter::WriteSourceRules(

path_output_.WriteFile(out_, sources[i]);

if (!input_dep.value().empty()) {

// Using "|" for the dependencies forces all implicit dependencies to be

- // fully up-to-date before running the action, and will re-run this

+ // fully up to date before running the action, and will re-run this

// action if any input dependencies change. This is important because

// this action may consume the outputs of previous steps.

out_ << " | ";

« no previous file with comments | « tools/gn/docs/reference.md ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »