Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc

Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ssl/chrome_security_state_model_client.h" 5 #include "chrome/browser/ssl/chrome_security_state_model_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 631
632 // Navigate to a page that doesn't finish loading. Test that the 632 // Navigate to a page that doesn't finish loading. Test that the
633 // security state is neutral while the page is loading. 633 // security state is neutral while the page is loading.
634 browser()->OpenURL(content::OpenURLParams(embedded_test_server()->GetURL("/"), 634 browser()->OpenURL(content::OpenURLParams(embedded_test_server()->GetURL("/"),
635 content::Referrer(), CURRENT_TAB, 635 content::Referrer(), CURRENT_TAB,
636 ui::PAGE_TRANSITION_TYPED, false)); 636 ui::PAGE_TRANSITION_TYPED, false));
637 CheckSecurityInfoForNonSecure( 637 CheckSecurityInfoForNonSecure(
638 browser()->tab_strip_model()->GetActiveWebContents()); 638 browser()->tab_strip_model()->GetActiveWebContents());
639 } 639 }
640 640
641 // Tests that the SecurityStateModel for a WebContents is up-to-date 641 // Tests that the SecurityStateModel for a WebContents is up to date
642 // when the WebContents is inserted into a Browser's TabStripModel. 642 // when the WebContents is inserted into a Browser's TabStripModel.
643 IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTest, AddedTab) { 643 IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTest, AddedTab) {
644 ASSERT_TRUE(https_server_.Start()); 644 ASSERT_TRUE(https_server_.Start());
645 SetUpMockCertVerifierForHttpsServer(0, net::OK); 645 SetUpMockCertVerifierForHttpsServer(0, net::OK);
646 646
647 content::WebContents* tab = 647 content::WebContents* tab =
648 browser()->tab_strip_model()->GetActiveWebContents(); 648 browser()->tab_strip_model()->GetActiveWebContents();
649 ASSERT_TRUE(tab); 649 ASSERT_TRUE(tab);
650 650
651 content::WebContents* new_contents = content::WebContents::Create( 651 content::WebContents* new_contents = content::WebContents::Create(
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
988 // downgraded: SECURE_PROTOCOL_AND_CIPHERSUITE should not show up when 988 // downgraded: SECURE_PROTOCOL_AND_CIPHERSUITE should not show up when
989 // the TLS settings are obsolete. 989 // the TLS settings are obsolete.
990 for (const auto& explanation : 990 for (const auto& explanation :
991 observer.latest_explanations().secure_explanations) { 991 observer.latest_explanations().secure_explanations) {
992 EXPECT_NE(l10n_util::GetStringUTF8(IDS_SECURE_PROTOCOL_AND_CIPHERSUITE), 992 EXPECT_NE(l10n_util::GetStringUTF8(IDS_SECURE_PROTOCOL_AND_CIPHERSUITE),
993 explanation.summary); 993 explanation.summary);
994 } 994 }
995 } 995 }
996 996
997 } // namespace 997 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/sessions/session_tab_helper.h ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698