Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp

Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Google Inc. All rights reserved. 2 * Copyright (c) 2013, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 if (loadAllFrames) { 98 if (loadAllFrames) {
99 for (size_t i = 0; i < frameCount; ++i) 99 for (size_t i = 0; i < frameCount; ++i)
100 frameAtIndex(i); 100 frameAtIndex(i);
101 } 101 }
102 } 102 }
103 103
104 size_t decodedSize() 104 size_t decodedSize()
105 { 105 {
106 // In the context of this test, the following loop will give the correct result, but only because the test 106 // In the context of this test, the following loop will give the correct result, but only because the test
107 // forces all frames to be decoded in loadImage() above. There is no gen eral guarantee that frameDecodedSize() 107 // forces all frames to be decoded in loadImage() above. There is no gen eral guarantee that frameDecodedSize()
108 // is up-to-date. Because of how multi frame images (like GIF) work, req uesting one frame to be decoded may 108 // is up to date. Because of how multi frame images (like GIF) work, req uesting one frame to be decoded may
109 // require other previous frames to be decoded as well. In those cases f rameDecodedSize() wouldn't return the 109 // require other previous frames to be decoded as well. In those cases f rameDecodedSize() wouldn't return the
110 // correct thing for the previous frame because the decoded size wouldn' t have propagated upwards to the 110 // correct thing for the previous frame because the decoded size wouldn' t have propagated upwards to the
111 // BitmapImage frame cache. 111 // BitmapImage frame cache.
112 size_t size = 0; 112 size_t size = 0;
113 for (size_t i = 0; i < decodedFramesCount(); ++i) 113 for (size_t i = 0; i < decodedFramesCount(); ++i)
114 size += frameDecodedSize(i); 114 size += frameDecodedSize(i);
115 return size; 115 return size;
116 } 116 }
117 117
118 void advanceAnimation() 118 void advanceAnimation()
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 {"/LayoutTests/fast/images/resources/exif-orientation-5-lu.jpg", OriginLeftT op}, 329 {"/LayoutTests/fast/images/resources/exif-orientation-5-lu.jpg", OriginLeftT op},
330 {"/LayoutTests/fast/images/resources/exif-orientation-6-ru.jpg", OriginRight Top}, 330 {"/LayoutTests/fast/images/resources/exif-orientation-6-ru.jpg", OriginRight Top},
331 {"/LayoutTests/fast/images/resources/exif-orientation-7-rl.jpg", OriginRight Bottom}, 331 {"/LayoutTests/fast/images/resources/exif-orientation-7-rl.jpg", OriginRight Bottom},
332 {"/LayoutTests/fast/images/resources/exif-orientation-8-llo.jpg", OriginLeft Bottom} 332 {"/LayoutTests/fast/images/resources/exif-orientation-8-llo.jpg", OriginLeft Bottom}
333 }; 333 };
334 334
335 INSTANTIATE_TEST_CASE_P(DecodedImageOrientationHistogramTest, DecodedImageOrient ationHistogramTest, 335 INSTANTIATE_TEST_CASE_P(DecodedImageOrientationHistogramTest, DecodedImageOrient ationHistogramTest,
336 ::testing::ValuesIn(kDecodedImageOrientationHistogramTestParams)); 336 ::testing::ValuesIn(kDecodedImageOrientationHistogramTestParams));
337 337
338 } // namespace blink 338 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698