Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Side by Side Diff: third_party/WebKit/Source/core/html/track/TextTrack.cpp

Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 if (cueTimeline()) 365 if (cueTimeline())
366 cueTimeline()->removeCue(this, cue); 366 cueTimeline()->removeCue(this, cue);
367 } 367 }
368 368
369 void TextTrack::cueDidChange(TextTrackCue* cue) 369 void TextTrack::cueDidChange(TextTrackCue* cue)
370 { 370 {
371 // This method is called through cue->track(), which should imply that this 371 // This method is called through cue->track(), which should imply that this
372 // track has a list of cues. 372 // track has a list of cues.
373 DCHECK(m_cues && cue->track() == this); 373 DCHECK(m_cues && cue->track() == this);
374 374
375 // Make sure the TextTrackCueList order is up-to-date. 375 // Make sure the TextTrackCueList order is up to date.
376 // FIXME: Only need to do this if the change was to any of the timestamps. 376 // FIXME: Only need to do this if the change was to any of the timestamps.
377 m_cues->updateCueIndex(cue); 377 m_cues->updateCueIndex(cue);
378 378
379 // Since a call to cueDidChange is always preceded by a call to 379 // Since a call to cueDidChange is always preceded by a call to
380 // cueWillChange, the cue should no longer be active when we reach this 380 // cueWillChange, the cue should no longer be active when we reach this
381 // point (since it was removed from the timeline in cueWillChange). 381 // point (since it was removed from the timeline in cueWillChange).
382 DCHECK(!cue->isActive()); 382 DCHECK(!cue->isActive());
383 383
384 if (m_mode == disabledKeyword()) 384 if (m_mode == disabledKeyword())
385 return; 385 return;
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
468 visitor->trace(m_trackList); 468 visitor->trace(m_trackList);
469 TrackBase::trace(visitor); 469 TrackBase::trace(visitor);
470 EventTargetWithInlineData::trace(visitor); 470 EventTargetWithInlineData::trace(visitor);
471 } 471 }
472 472
473 DEFINE_TRACE_WRAPPERS(TextTrack) 473 DEFINE_TRACE_WRAPPERS(TextTrack)
474 { 474 {
475 visitor->traceWrappers(m_cues); 475 visitor->traceWrappers(m_cues);
476 } 476 }
477 } // namespace blink 477 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698