Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: .gn

Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ash/system/chromeos/power/tray_power.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # This file is used by the GN meta build system to find the root of the source 1 # This file is used by the GN meta build system to find the root of the source
2 # tree and to set startup options. For documentation on the values set in this 2 # tree and to set startup options. For documentation on the values set in this
3 # file, run "gn help dotfile" at the command line. 3 # file, run "gn help dotfile" at the command line.
4 4
5 # The location of the build configuration file. 5 # The location of the build configuration file.
6 buildconfig = "//build/config/BUILDCONFIG.gn" 6 buildconfig = "//build/config/BUILDCONFIG.gn"
7 7
8 # The secondary source root is a parallel directory tree where 8 # The secondary source root is a parallel directory tree where
9 # GN build files are placed when they can not be placed directly 9 # GN build files are placed when they can not be placed directly
10 # in the source tree, e.g. for third party source trees. 10 # in the source tree, e.g. for third party source trees.
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 # surprising effects. 208 # surprising effects.
209 # 209 #
210 # - It becomes impossible to use "git grep" to find where a certain file is 210 # - It becomes impossible to use "git grep" to find where a certain file is
211 # referenced. This operation is very common and people really do get 211 # referenced. This operation is very common and people really do get
212 # confused when things aren't listed. 212 # confused when things aren't listed.
213 # 213 #
214 # - It's easy to screw up. One common case is a build-time script that packs 214 # - It's easy to screw up. One common case is a build-time script that packs
215 # up a directory. The author notices that the script isn't re-run when the 215 # up a directory. The author notices that the script isn't re-run when the
216 # directory is updated, so adds a glob so all the files are listed as 216 # directory is updated, so adds a glob so all the files are listed as
217 # inputs. This seems to work great... until a file is deleted. When a 217 # inputs. This seems to work great... until a file is deleted. When a
218 # file is deleted, all the inputs the glob lists will still be up-to-date 218 # file is deleted, all the inputs the glob lists will still be up to date
219 # and no command-lines will have been changed. The action will not be 219 # and no command-lines will have been changed. The action will not be
220 # re-run and the build will be broken. It is possible to get this correct 220 # re-run and the build will be broken. It is possible to get this correct
221 # using glob, and it's possible to mess it up without glob, but globs make 221 # using glob, and it's possible to mess it up without glob, but globs make
222 # this situation much easier to create. if the build always lists the 222 # this situation much easier to create. if the build always lists the
223 # files and passes them to a script, it will always be correct. 223 # files and passes them to a script, it will always be correct.
224 exec_script_whitelist = [ 224 exec_script_whitelist = [
225 "//android_webview/BUILD.gn", 225 "//android_webview/BUILD.gn",
226 "//ash/BUILD.gn", 226 "//ash/BUILD.gn",
227 "//build/config/BUILD.gn", 227 "//build/config/BUILD.gn",
228 "//build/config/android/config.gni", 228 "//build/config/android/config.gni",
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 "//tools/gn/function_exec_script.cc", 325 "//tools/gn/function_exec_script.cc",
326 "//tools/gn/gn.gyp", 326 "//tools/gn/gn.gyp",
327 "//tools/gn/input_conversion.cc", 327 "//tools/gn/input_conversion.cc",
328 "//tools/gn/misc/emacs/gn.el", 328 "//tools/gn/misc/emacs/gn.el",
329 "//tools/gn/misc/vim/syntax/gn.vim", 329 "//tools/gn/misc/vim/syntax/gn.vim",
330 "//tools/gn/setup.cc", 330 "//tools/gn/setup.cc",
331 "//ui/accessibility/BUILD.gn", 331 "//ui/accessibility/BUILD.gn",
332 "//ui/views/BUILD.gn", 332 "//ui/views/BUILD.gn",
333 "//ui/views/mus/BUILD.gn", 333 "//ui/views/mus/BUILD.gn",
334 ] 334 ]
OLDNEW
« no previous file with comments | « no previous file | ash/system/chromeos/power/tray_power.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698