tools/gn/ninja_binary_target_writer.cc - Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_binary_target_writer.cc

diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc

index 30658f21ed155973a44be8c8bced91044a185c2e..b012e42b0088a0106ffaa01ae1d5421dd6a38fef 100644

--- a/tools/gn/ninja_binary_target_writer.cc

+++ b/tools/gn/ninja_binary_target_writer.cc

@@ -271,7 +271,7 @@ void NinjaBinaryTargetWriter::Run() {

WriteCompilerVars(used_types);

// The input dependencies will be an order-only dependency. This will cause

- // Ninja to make sure the inputs are up-to-date before compiling this source,

+ // Ninja to make sure the inputs are up to date before compiling this source,

// but changes in the inputs deps won't cause the file to be recompiled.

// This is important to prevent changes in unrelated actions that are

« no previous file with comments | « tools/gn/ninja_action_target_writer.cc ('k') | tools/gn/variables.cc » ('j') | no next file with comments »