chrome/browser/ui/toolbar/toolbar_actions_model.cc - Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_model.cc

Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/toolbar/toolbar_actions_model.cc

diff --git a/chrome/browser/ui/toolbar/toolbar_actions_model.cc b/chrome/browser/ui/toolbar/toolbar_actions_model.cc

index 5c56390db3a1f55b7c6725d5606fbfb3249ac2b2..bae5b67c1d63177c66b78a040f2e8886bbb1cb80 100644

--- a/chrome/browser/ui/toolbar/toolbar_actions_model.cc

+++ b/chrome/browser/ui/toolbar/toolbar_actions_model.cc

@@ -750,7 +750,7 @@ void ToolbarActionsModel::OnActionToolbarPrefChange() {

std::rotate(current_pos, current_pos + 1, desired_pos + 1);

else

std::rotate(desired_pos, current_pos, current_pos + 1);

- // Notify the observers to keep them up-to-date, unless we're highlighting

+ // Notify the observers to keep them up to date, unless we're highlighting

// (in which case we're deliberately only showing a subset of actions).

if (!is_highlighting())

FOR_EACH_OBSERVER(

« no previous file with comments | « chrome/browser/ui/pdf/pdf_unsupported_feature.cc ('k') | chrome/browser/ui/webui/help/version_updater_chromeos.cc » ('j') | no next file with comments »