Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: sync/internal_api/sync_manager_impl.cc

Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/internal_api/sync_manager_impl.h" 5 #include "sync/internal_api/sync_manager_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 806 matching lines...) Expand 10 before | Expand all | Expand 10 after
817 817
818 void SyncManagerImpl::NudgeForRefresh(syncer::ModelType type) { 818 void SyncManagerImpl::NudgeForRefresh(syncer::ModelType type) {
819 DCHECK(thread_checker_.CalledOnValidThread()); 819 DCHECK(thread_checker_.CalledOnValidThread());
820 RefreshTypes(ModelTypeSet(type)); 820 RefreshTypes(ModelTypeSet(type));
821 } 821 }
822 822
823 void SyncManagerImpl::OnSyncCycleEvent(const SyncCycleEvent& event) { 823 void SyncManagerImpl::OnSyncCycleEvent(const SyncCycleEvent& event) {
824 DCHECK(thread_checker_.CalledOnValidThread()); 824 DCHECK(thread_checker_.CalledOnValidThread());
825 // Only send an event if this is due to a cycle ending and this cycle 825 // Only send an event if this is due to a cycle ending and this cycle
826 // concludes a canonical "sync" process; that is, based on what is known 826 // concludes a canonical "sync" process; that is, based on what is known
827 // locally we are "all happy" and up-to-date. There may be new changes on 827 // locally we are "all happy" and up to date. There may be new changes on
828 // the server, but we'll get them on a subsequent sync. 828 // the server, but we'll get them on a subsequent sync.
829 // 829 //
830 // Notifications are sent at the end of every sync cycle, regardless of 830 // Notifications are sent at the end of every sync cycle, regardless of
831 // whether we should sync again. 831 // whether we should sync again.
832 if (event.what_happened == SyncCycleEvent::SYNC_CYCLE_ENDED) { 832 if (event.what_happened == SyncCycleEvent::SYNC_CYCLE_ENDED) {
833 if (!initialized_) { 833 if (!initialized_) {
834 DVLOG(1) << "OnSyncCycleCompleted not sent because sync api is not " 834 DVLOG(1) << "OnSyncCycleCompleted not sent because sync api is not "
835 << "initialized"; 835 << "initialized";
836 return; 836 return;
837 } 837 }
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
1027 } 1027 }
1028 1028
1029 void SyncManagerImpl::OnCookieJarChanged(bool account_mismatch, 1029 void SyncManagerImpl::OnCookieJarChanged(bool account_mismatch,
1030 bool empty_jar) { 1030 bool empty_jar) {
1031 DCHECK(thread_checker_.CalledOnValidThread()); 1031 DCHECK(thread_checker_.CalledOnValidThread());
1032 session_context_->set_cookie_jar_mismatch(account_mismatch); 1032 session_context_->set_cookie_jar_mismatch(account_mismatch);
1033 session_context_->set_cookie_jar_empty(empty_jar); 1033 session_context_->set_cookie_jar_empty(empty_jar);
1034 } 1034 }
1035 1035
1036 } // namespace syncer 1036 } // namespace syncer
OLDNEW
« no previous file with comments | « remoting/host/mac/me2me_preference_pane.mm ('k') | third_party/WebKit/LayoutTests/accessibility/bounds-calc.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698