build/install-build-deps.sh - Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/install-build-deps.sh

Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java ('k') | build/linux/install-chromeos-fonts.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/install-build-deps.sh

diff --git a/build/install-build-deps.sh b/build/install-build-deps.sh

index 3dd36d0bdf0b1726174ce6592ea76c7dcf858896..f0ae0b14079c773262317d29c31b189ab87191a8 100755

--- a/build/install-build-deps.sh

+++ b/build/install-build-deps.sh

@@ -424,7 +424,7 @@ echo

new_list_cmd="sudo apt-get install --reinstall $(echo $packages)"

if new_list="$(yes n | LANGUAGE=en LANG=C $new_list_cmd)"; then

# We probably never hit this following line.

- echo "No missing packages, and the packages are up-to-date."

+ echo "No missing packages, and the packages are up to date."

elif [ $? -eq 1 ]; then

# We expect apt-get to have exit status of 1.

# This indicates that we cancelled the install with "yes n|".

@@ -432,7 +432,7 @@ elif [ $? -eq 1 ]; then

sed -e '1,/The following NEW packages will be installed:/d;s/^ //;t;d')

new_list=$(echo "$new_list" | sed 's/ *$//')

if [ -z "$new_list" ] ; then

- echo "No missing packages, and the packages are up-to-date."

+ echo "No missing packages, and the packages are up to date."

else

echo "Installing missing packages: $new_list."

sudo apt-get install ${do_quietly-} ${new_list}