Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: components/signin/core/browser/signin_metrics.h

Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_ 5 #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_
6 #define COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_ 6 #define COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_
7 7
8 #include <limits.h> 8 #include <limits.h>
9 9
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 // Unable to read the variations configuration. 198 // Unable to read the variations configuration.
199 NO_VARIATIONS_CONFIG, 199 NO_VARIATIONS_CONFIG,
200 // Always the last enumerated type. 200 // Always the last enumerated type.
201 NUM_CROSS_DEVICE_PROMO_INITIALIZED_METRICS 201 NUM_CROSS_DEVICE_PROMO_INITIALIZED_METRICS
202 }; 202 };
203 203
204 // Enum values used for "Signin.AccountReconcilorState.OnGaiaResponse" 204 // Enum values used for "Signin.AccountReconcilorState.OnGaiaResponse"
205 // histogram, which records the state of the AccountReconcilor when GAIA returns 205 // histogram, which records the state of the AccountReconcilor when GAIA returns
206 // a specific response. 206 // a specific response.
207 enum AccountReconcilorState { 207 enum AccountReconcilorState {
208 // The AccountReconcilor has finished running ans is up-to-date. 208 // The AccountReconcilor has finished running ans is up to date.
209 ACCOUNT_RECONCILOR_OK, 209 ACCOUNT_RECONCILOR_OK,
210 // The AccountReconcilor is running and gathering information. 210 // The AccountReconcilor is running and gathering information.
211 ACCOUNT_RECONCILOR_RUNNING, 211 ACCOUNT_RECONCILOR_RUNNING,
212 // The AccountReconcilor encountered an error and stopped. 212 // The AccountReconcilor encountered an error and stopped.
213 ACCOUNT_RECONCILOR_ERROR, 213 ACCOUNT_RECONCILOR_ERROR,
214 // Always the last enumerated type. 214 // Always the last enumerated type.
215 ACCOUNT_RECONCILOR_HISTOGRAM_COUNT, 215 ACCOUNT_RECONCILOR_HISTOGRAM_COUNT,
216 }; 216 };
217 217
218 // Values of histogram comparing account id and email. 218 // Values of histogram comparing account id and email.
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 // be shown a different set of accounts in the content-area and the settings UI. 310 // be shown a different set of accounts in the content-area and the settings UI.
311 void LogAccountReconcilorStateOnGaiaResponse(AccountReconcilorState state); 311 void LogAccountReconcilorStateOnGaiaResponse(AccountReconcilorState state);
312 312
313 // Records the AccountEquality metric when an investigator compares the current 313 // Records the AccountEquality metric when an investigator compares the current
314 // and previous id/emails during a signin. 314 // and previous id/emails during a signin.
315 void LogAccountEquality(AccountEquality equality); 315 void LogAccountEquality(AccountEquality equality);
316 316
317 } // namespace signin_metrics 317 } // namespace signin_metrics
318 318
319 #endif // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_ 319 #endif // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_
OLDNEW
« no previous file with comments | « components/search_provider_logos/logo_tracker.h ('k') | components/update_client/action_update_check.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698