Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
CC:
aboxhall, ajuma+watch_chromium.org, ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, danakj+watch_chromium.org, dcheng, devtools-reviews_chromium.org, dglazkov+blink, dmazzoni, dominicc+watchlist_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, f(malita), fs, gavinp+loader_chromium.org, gyuyoung2, Nate Chapin, jbroman, jchaffraix+rendering, je_julie, Justin Novosad, kenneth.christiansen, kinuko+watch, kinuko+fileapi, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loading-reviews+fetch_chromium.org, lushnikov+blink_chromium.org, Mikhail, mlamouri+watch-blink_chromium.org, nektarios, nhiroki, pdr+svgwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, sof, szager+layoutwatch_chromium.org, tyoshino+watch_chromium.org, tzik, yhirano+watch_chromium.org, Yoav Weiss, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove StringBuilder::appendLiteral. (patchset #1 id:1 of https://codereview.chromium.org/2017053003/ ) Reason for revert: Will unfortunately have to back out this one so that the revert https://codereview.chromium.org/2025503002/ will cleanly apply. (Don't want a tree with this many ASan failures over the long weekend.) Original issue's description: > Remove StringBuilder::appendLiteral. > > We can just rely on the append(StringView) version instead. This does > mean we have to take 2 branches in some cases, but it should be > very minimal and since the code is inline the compiler can also > likely eliminate it. > > BUG=615174 > > Committed: https://crrev.com/04157e8b89881d033f9eeca4466d9dd0c4e9aaea > Cr-Commit-Position: refs/heads/master@{#396601} TBR=haraken@chromium.org,yutak@chromium.org,esprehn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=615174 Committed: https://crrev.com/433566e878a7ce453ae7be38e0d252f8cf804411 Cr-Commit-Position: refs/heads/master@{#396640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -378 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h View 3 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp View 6 chunks +23 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCalculationValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSCounterValue.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFaceRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFeatureValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSGradientValue.cpp View 12 chunks +34 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSGroupingRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageSetValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSImportRule.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSMediaRule.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSNamespaceRule.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPageRule.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPaintValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelector.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelectorList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleRule.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSSupportsRule.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSViewportRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaQuery.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryExp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaQuerySetTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp View 7 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRuleKeyframe.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParser.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DatasetDOMStringMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SandboxFlags.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/HTMLInterchange.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp View 7 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/FormController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ScriptArguments.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/page/EventSource.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/page/FrameTree.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParsingError.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLErrors.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Decimal.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/JSONValues.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/PODInterval.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp View 6 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Color.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp View 3 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/text/DateTimeFormat.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/DateTimeFormat.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleICUTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleWin.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/text/PlatformLocale.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/DateMath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/InstanceCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringBuilder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringBuilderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
sof
Created Revert of Remove StringBuilder::appendLiteral.
4 years, 6 months ago (2016-05-28 11:48:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017303002/1
4 years, 6 months ago (2016-05-28 11:48:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-28 11:50:14 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-28 11:51:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/433566e878a7ce453ae7be38e0d252f8cf804411
Cr-Commit-Position: refs/heads/master@{#396640}

Powered by Google App Engine
This is Rietveld 408576698