third_party/WebKit/Source/web/WebAXObject.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebAXObject.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebAXObject.cpp

diff --git a/third_party/WebKit/Source/web/WebAXObject.cpp b/third_party/WebKit/Source/web/WebAXObject.cpp

index 18b82a2567520e7fe9342e589acb7d8b3358b80f..ae4ec4409ea3c6fbf32ee94ccb567f79130d2c5b 100644

--- a/third_party/WebKit/Source/web/WebAXObject.cpp

+++ b/third_party/WebKit/Source/web/WebAXObject.cpp

@@ -757,13 +757,13 @@

// should not be localized and defines the separator as "+".

StringBuilder modifierStringBuilder;

if (modifiers & PlatformEvent::CtrlKey)

- modifierStringBuilder.append("Ctrl+");

+ modifierStringBuilder.appendLiteral("Ctrl+");

if (modifiers & PlatformEvent::AltKey)

- modifierStringBuilder.append("Alt+");

+ modifierStringBuilder.appendLiteral("Alt+");

if (modifiers & PlatformEvent::ShiftKey)

- modifierStringBuilder.append("Shift+");

+ modifierStringBuilder.appendLiteral("Shift+");

if (modifiers & PlatformEvent::MetaKey)

- modifierStringBuilder.append("Win+");

+ modifierStringBuilder.appendLiteral("Win+");

modifierString = modifierStringBuilder.toString();

}