Revert of Remove StringBuilder::appendLiteral.

third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 131 matching lines @@
             if (!param->haveSeenDocType) {
                 param->haveSeenDocType = true;
                 result.append(createMarkup(param->document->doctype()));
             }
 
             // Add MOTW declaration before html tag.
             // See http://msdn2.microsoft.com/en-us/library/ms537628(VS.85).aspx.
             result.append(WebFrameSerializer::generateMarkOfTheWebDeclaration(param->url));
         } else if (isHTMLBaseElement(*element)) {
             // Comment the BASE tag when serializing dom.
-            result.append("<!--");
+            result.appendLiteral("<!--");
         }
     } else {
         // Write XML declaration.
         if (!param->haveAddedXMLProcessingDirective) {
             param->haveAddedXMLProcessingDirective = true;
             // Get encoding info.
             String xmlEncoding = param->document->xmlEncoding();
             if (xmlEncoding.isEmpty())
                 xmlEncoding = param->document->encodingName();
             if (xmlEncoding.isEmpty())
                 xmlEncoding = UTF8Encoding().name();
-            result.append("<?xml version=\"");
+            result.appendLiteral("<?xml version=\"");
             result.append(param->document->xmlVersion());
-            result.append("\" encoding=\"");
+            result.appendLiteral("\" encoding=\"");
             result.append(xmlEncoding);
             if (param->document->xmlStandalone())
-                result.append("\" standalone=\"yes");
-            result.append("\"?>\n");
+                result.appendLiteral("\" standalone=\"yes");
+            result.appendLiteral("\"?>\n");
         }
         // Add doc type declaration if original document has it.
         if (!param->haveSeenDocType) {
             param->haveSeenDocType = true;
             result.append(createMarkup(param->document->doctype()));
         }
     }
     return result.toString();
 }
 
@@ skipping 49 matching lines @@
 // element a chance to do some post work to add some additional data.
 String WebFrameSerializerImpl::postActionAfterSerializeEndTag(
     const Element* element, SerializeDomParam* param)
 {
     StringBuilder result;
 
     if (!param->isHTMLDocument)
         return result.toString();
     // Comment the BASE tag when serializing DOM.
     if (isHTMLBaseElement(*element)) {
-        result.append("-->");
+        result.appendLiteral("-->");
         // Append a new base tag declaration.
         result.append(WebFrameSerializer::generateBaseTagDeclaration(
             param->document->baseTarget()));
     }
 
     return result.toString();
 }
 
 void WebFrameSerializerImpl::saveHTMLContentToBuffer(
     const String& result, SerializeDomParam* param)
@@ skipping 26 matching lines @@
 // TODO(yosin): We should utilize |MarkupFormatter| here to share code,
 // especially escaping attribute values, done by |WebEntities| |m_htmlEntities|
 // and |m_xmlEntities|.
 void WebFrameSerializerImpl::appendAttribute(
     StringBuilder& result,
     bool isHTMLDocument,
     const String& attrName,
     const String& attrValue) {
     result.append(' ');
     result.append(attrName);
-    result.append("=\"");
+    result.appendLiteral("=\"");
     if (isHTMLDocument)
         result.append(m_htmlEntities.convertEntitiesInString(attrValue));
     else
         result.append(m_xmlEntities.convertEntitiesInString(attrValue));
     result.append('\"');
 }
 
 void WebFrameSerializerImpl::openTagToString(
     Element* element,
     SerializeDomParam* param)
@@ skipping 76 matching lines @@
     SerializeDomParam* param)
 {
     bool needSkip;
     StringBuilder result;
     // Do pre action for end tag.
     result.append(preActionBeforeSerializeEndTag(element, param, &needSkip));
     if (needSkip)
         return;
     // Write end tag when element has child/children.
     if (element->hasChildren() || param->haveAddedContentsBeforeEnd) {
-        result.append("</");
+        result.appendLiteral("</");
         result.append(element->nodeName().lower());
         result.append('>');
     } else {
         // Check whether we have to write end tag for empty element.
         if (param->isHTMLDocument) {
             result.append('>');
             // FIXME: This code is horribly wrong.  WebFrameSerializerImpl must die.
             if (!element->isHTMLElement() || !toHTMLElement(element)->ieForbidsInsertHTML()) {
                 // We need to write end tag when it is required.
-                result.append("</");
+                result.appendLiteral("</");
                 result.append(element->nodeName().lower());
                 result.append('>');
             }
         } else {
             // For xml base document.
-            result.append(" />");
+            result.appendLiteral(" />");
         }
     }
     // Do post action for end tag.
     result.append(postActionAfterSerializeEndTag(element, param));
     // Save the result to data buffer.
     saveHTMLContentToBuffer(result.toString(), param);
 }
 
 void WebFrameSerializerImpl::buildContentForNode(
     Node* node,
@@ skipping 74 matching lines @@
         // Report empty contents for invalid URLs.
         m_client->didSerializeDataForFrame(
             WebCString(), WebFrameSerializerClient::CurrentFrameIsFinished);
     }
 
     DCHECK(m_dataBuffer.isEmpty());
     return didSerialization;
 }
 
 } // namespace blink