third_party/WebKit/Source/core/xml/parser/XMLErrors.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xml/parser/XMLErrors.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/xml/parser/XMLErrors.cpp

diff --git a/third_party/WebKit/Source/core/xml/parser/XMLErrors.cpp b/third_party/WebKit/Source/core/xml/parser/XMLErrors.cpp

index 2f382cca24ba2d143086e88012b7795c18f593ef..36c1b22431b5dbe0fe366666019c433ec129ab61 100644

--- a/third_party/WebKit/Source/core/xml/parser/XMLErrors.cpp

+++ b/third_party/WebKit/Source/core/xml/parser/XMLErrors.cpp

@@ -80,11 +80,11 @@

{

// <typeString> on line <lineNumber> at column <columnNumber>: <message>

m_errorMessages.append(typeString);

- m_errorMessages.append(" on line ");

+ m_errorMessages.appendLiteral(" on line ");

m_errorMessages.appendNumber(position.m_line.oneBasedInt());

- m_errorMessages.append(" at column ");

+ m_errorMessages.appendLiteral(" at column ");

m_errorMessages.appendNumber(position.m_column.oneBasedInt());

- m_errorMessages.append(": ");

+ m_errorMessages.appendLiteral(": ");

m_errorMessages.append(message);

}