third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp

diff --git a/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp b/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp

index 980c34d1e146e8f8fc214d01681167d2678c1654..64930daeeba97d199ed92cc21b8ec4a8681e4f8c 100644

--- a/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp

+++ b/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp

@@ -67,13 +67,13 @@

StringBuilder filesystemName;

filesystemName.append(Platform::current()->fileSystemCreateOriginIdentifier(WebSecurityOrigin(context->getSecurityOrigin())));

- filesystemName.append(":Isolated_");

+ filesystemName.appendLiteral(":Isolated_");

filesystemName.append(filesystemId);

// The rootURL created here is going to be attached to each filesystem request and

// is to be validated each time the request is being handled.

StringBuilder rootURL;

- rootURL.append("filesystem:");

+ rootURL.appendLiteral("filesystem:");

rootURL.append(context->getSecurityOrigin()->toString());

rootURL.append('/');

rootURL.append(isolatedPathPrefix);