third_party/WebKit/Source/core/css/CSSStyleRule.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSStyleRule.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSStyleRule.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSStyleRule.cpp b/third_party/WebKit/Source/core/css/CSSStyleRule.cpp

index fe4cbb963757f3941363c1ae0f77b94f7d31ec66..9dd5e58648ed40f26c6d09dffefceaee61557458 100644

--- a/third_party/WebKit/Source/core/css/CSSStyleRule.cpp

+++ b/third_party/WebKit/Source/core/css/CSSStyleRule.cpp

@@ -62,7 +62,7 @@

StringBuilder builder;

for (const CSSSelector* selector = m_styleRule->selectorList().first(); selector; selector = CSSSelectorList::next(*selector)) {

if (selector != m_styleRule->selectorList().first())

- builder.append(", ");

+ builder.appendLiteral(", ");

builder.append(selector->selectorText());

}

return builder.toString();

@@ -103,7 +103,7 @@

{

StringBuilder result;

result.append(selectorText());

- result.append(" { ");

+ result.appendLiteral(" { ");

String decls = m_styleRule->properties().asText();

result.append(decls);

if (!decls.isEmpty())