third_party/WebKit/Source/platform/text/DateTimeFormat.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/DateTimeFormat.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/DateTimeFormat.cpp

diff --git a/third_party/WebKit/Source/platform/text/DateTimeFormat.cpp b/third_party/WebKit/Source/platform/text/DateTimeFormat.cpp

index 8c1a6832312f272b16f57dafbd6f67595a12f46c..261458051383f7a2c5d494ddc103fff41ad77f72 100644

--- a/third_party/WebKit/Source/platform/text/DateTimeFormat.cpp

+++ b/third_party/WebKit/Source/platform/text/DateTimeFormat.cpp

@@ -244,7 +244,7 @@

return isASCIIAlpha(ch) || ch == '\'';

}

-void DateTimeFormat::quoteAndappend(const String& literal, StringBuilder& buffer)

+void DateTimeFormat::quoteAndAppendLiteral(const String& literal, StringBuilder& buffer)

{

if (literal.length() <= 0)

return;

@@ -263,7 +263,7 @@

for (unsigned i = 0; i < literal.length(); ++i) {

if (literal[i] == '\'') {

- buffer.append("''");

+ buffer.appendLiteral("''");

} else {

String escaped = literal.substring(i);

escaped.replace("'", "''");