third_party/WebKit/Source/platform/text/PlatformLocale.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/PlatformLocale.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/PlatformLocale.cpp

diff --git a/third_party/WebKit/Source/platform/text/PlatformLocale.cpp b/third_party/WebKit/Source/platform/text/PlatformLocale.cpp

index 3641a7c7935578b7e6912e56efe8905f2bb57e4c..99b7fd7ce7cd4171ed22d153588db19fce6cd738 100644

--- a/third_party/WebKit/Source/platform/text/PlatformLocale.cpp

+++ b/third_party/WebKit/Source/platform/text/PlatformLocale.cpp

@@ -224,13 +224,13 @@

for (unsigned i = 0; i + 1 < length; ++i) {

if (templ[i] == '$' && (templ[i + 1] == '1' || templ[i + 1] == '2')) {

if (literalStart < i)

- DateTimeFormat::quoteAndappend(templ.substring(literalStart, i - literalStart), builder);

+ DateTimeFormat::quoteAndAppendLiteral(templ.substring(literalStart, i - literalStart), builder);

builder.append(templ[++i] == '1' ? "yyyy" : "ww");

literalStart = i + 1;

}

if (literalStart < length)

- DateTimeFormat::quoteAndappend(templ.substring(literalStart, length - literalStart), builder);

+ DateTimeFormat::quoteAndAppendLiteral(templ.substring(literalStart, length - literalStart), builder);

return builder.toString();

}