third_party/WebKit/Source/core/css/parser/CSSParser.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParser.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSParser.cpp

index 8f203792c900b3d538cc5e913921230e85989d96..6f892e08afeda035bc1f9b8a592eafbf79de78ee 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSParser.cpp

@@ -171,11 +171,11 @@

CSSValue* CSSParser::parseFontFaceDescriptor(CSSPropertyID propertyID, const String& propertyValue, const CSSParserContext& context)

{

StringBuilder builder;

- builder.append("@font-face { ");

+ builder.appendLiteral("@font-face { ");

builder.append(getPropertyNameString(propertyID));

- builder.append(" : ");

+ builder.appendLiteral(" : ");

builder.append(propertyValue);

- builder.append("; }");

+ builder.appendLiteral("; }");

StyleRuleBase* rule = parseRule(context, nullptr, builder.toString());

if (!rule || !rule->isFontFaceRule())

return nullptr;