Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPageRule.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * (C) 2002-2003 Dirk Mueller (mueller@kde.org) 3 * (C) 2002-2003 Dirk Mueller (mueller@kde.org)
4 * Copyright (C) 2002, 2005, 2006, 2008, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2002, 2005, 2006, 2008, 2012 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 return; 68 return;
69 69
70 CSSStyleSheet::RuleMutationScope mutationScope(this); 70 CSSStyleSheet::RuleMutationScope mutationScope(this);
71 71
72 m_pageRule->wrapperAdoptSelectorList(std::move(selectorList)); 72 m_pageRule->wrapperAdoptSelectorList(std::move(selectorList));
73 } 73 }
74 74
75 String CSSPageRule::cssText() const 75 String CSSPageRule::cssText() const
76 { 76 {
77 StringBuilder result; 77 StringBuilder result;
78 result.append("@page "); 78 result.appendLiteral("@page ");
79 String pageSelectors = selectorText(); 79 String pageSelectors = selectorText();
80 result.append(pageSelectors); 80 result.append(pageSelectors);
81 if (!pageSelectors.isEmpty()) 81 if (!pageSelectors.isEmpty())
82 result.append(" "); 82 result.appendLiteral(" ");
83 result.append("{ "); 83 result.appendLiteral("{ ");
84 String decls = m_pageRule->properties().asText(); 84 String decls = m_pageRule->properties().asText();
85 result.append(decls); 85 result.append(decls);
86 if (!decls.isEmpty()) 86 if (!decls.isEmpty())
87 result.append(' '); 87 result.append(' ');
88 result.append('}'); 88 result.append('}');
89 return result.toString(); 89 return result.toString();
90 } 90 }
91 91
92 void CSSPageRule::reattach(StyleRuleBase* rule) 92 void CSSPageRule::reattach(StyleRuleBase* rule)
93 { 93 {
94 ASSERT(rule); 94 ASSERT(rule);
95 m_pageRule = toStyleRulePage(rule); 95 m_pageRule = toStyleRulePage(rule);
96 if (m_propertiesCSSOMWrapper) 96 if (m_propertiesCSSOMWrapper)
97 m_propertiesCSSOMWrapper->reattach(m_pageRule->mutableProperties()); 97 m_propertiesCSSOMWrapper->reattach(m_pageRule->mutableProperties());
98 } 98 }
99 99
100 DEFINE_TRACE(CSSPageRule) 100 DEFINE_TRACE(CSSPageRule)
101 { 101 {
102 visitor->trace(m_pageRule); 102 visitor->trace(m_pageRule);
103 visitor->trace(m_propertiesCSSOMWrapper); 103 visitor->trace(m_propertiesCSSOMWrapper);
104 CSSRule::trace(visitor); 104 CSSRule::trace(visitor);
105 } 105 }
106 106
107 } // namespace blink 107 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSNamespaceRule.cpp ('k') | third_party/WebKit/Source/core/css/CSSPaintValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698