third_party/WebKit/Source/platform/text/LocaleICUTest.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/LocaleICUTest.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/LocaleICUTest.cpp

diff --git a/third_party/WebKit/Source/platform/text/LocaleICUTest.cpp b/third_party/WebKit/Source/platform/text/LocaleICUTest.cpp

index 256467bcfa46319c83671d9826c55652006513d3..729f0b2eef96cfde4d8fd68433a785f24a7c60c0 100644

--- a/third_party/WebKit/Source/platform/text/LocaleICUTest.cpp

+++ b/third_party/WebKit/Source/platform/text/LocaleICUTest.cpp

@@ -62,10 +62,10 @@

String toString() const

{

StringBuilder builder;

- builder.append("labels(");

+ builder.appendLiteral("labels(");

for (unsigned index = 0; index < m_labels.size(); ++index) {

if (index)

- builder.append(", ");

+ builder.appendLiteral(", ");

builder.append('"');

builder.append(m_labels[index]);

builder.append('"');