third_party/WebKit/Source/platform/graphics/Color.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/Color.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp ('k') | third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/Color.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/Color.cpp b/third_party/WebKit/Source/platform/graphics/Color.cpp

index 15506ea9067002c0c8c563e09b1d9904b19a9fe3..aefac181936d30089ca11d4d0cc5cde04c203ad2 100644

--- a/third_party/WebKit/Source/platform/graphics/Color.cpp

+++ b/third_party/WebKit/Source/platform/graphics/Color.cpp

@@ -198,19 +198,19 @@

result.reserveCapacity(32);

bool colorHasAlpha = hasAlpha();

if (colorHasAlpha)

- result.append("rgba(");

+ result.appendLiteral("rgba(");

else

- result.append("rgb(");

+ result.appendLiteral("rgb(");

result.appendNumber(static_cast<unsigned char>(red()));

- result.append(", ");

+ result.appendLiteral(", ");

result.appendNumber(static_cast<unsigned char>(green()));

- result.append(", ");

+ result.appendLiteral(", ");

result.appendNumber(static_cast<unsigned char>(blue()));

if (colorHasAlpha) {

- result.append(", ");

+ result.appendLiteral(", ");

NumberToStringBuffer buffer;

const char* alphaString = numberToFixedPrecisionString(alpha() / 255.0f, 6, buffer, true);

@@ -236,13 +236,13 @@

StringBuilder result;

result.reserveCapacity(28);

- result.append("rgba(");

+ result.appendLiteral("rgba(");

result.appendNumber(red());

- result.append(", ");

+ result.appendLiteral(", ");

result.appendNumber(green());

- result.append(", ");

+ result.appendLiteral(", ");

result.appendNumber(blue());

- result.append(", ");

+ result.appendLiteral(", ");

if (!alpha())

result.append('0');