third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp - Issue 2017303002: Revert of Remove StringBuilder::appendLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp

Issue 2017303002: Revert of Remove StringBuilder::appendLiteral. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp

index d9222e244784b51c531d56c0abc5ad20e668cb05..fc6abba2e7938de6d11d57ee5950b5b2e02664e4 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp

@@ -175,19 +175,19 @@

{

StringBuilder builder;

if (resourceInfo.m_isMaster)

- builder.append("Master ");

+ builder.appendLiteral("Master ");

if (resourceInfo.m_isManifest)

- builder.append("Manifest ");

+ builder.appendLiteral("Manifest ");

if (resourceInfo.m_isFallback)

- builder.append("Fallback ");

+ builder.appendLiteral("Fallback ");

if (resourceInfo.m_isForeign)

- builder.append("Foreign ");

+ builder.appendLiteral("Foreign ");

if (resourceInfo.m_isExplicit)

- builder.append("Explicit ");

+ builder.appendLiteral("Explicit ");

std::unique_ptr<protocol::ApplicationCache::ApplicationCacheResource> value = protocol::ApplicationCache::ApplicationCacheResource::create()

.setUrl(resourceInfo.m_resource.getString())