Run format-webkit on webkitpy code (without string conversion).

Run format-webkit on webkitpy code (without string conversion).

This is a follow-up to http://crrev.com/1839193004; the auto-formatting done
by this CL is similar to that done in that CL, except ./format-webkitpy calls
autopep8 with --aggressive.

Specifically:

  ./format-webkitpy --leave-strings-alone --no-backups $(find . -name '*.py' | grep -v thirdparty)

Also ran the same command on the Python files in Tools/Scripts.

BUG=598897
Committed: https://crrev.com/32c236f5f3e81f364347723909d45971eb713400
Cr-Commit-Position: refs/heads/master@{#397453}

[qyearsley, 2016-05-25 22:23:10]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org, prasadv@chromium.org, tansell@chromium.org

[qyearsley, 2016-05-25 22:23:12]

Note: There are a couple places where I think it wraps more than necessary, but
overall I think it works well, and this tool seems to format things as we want
them.

After this, I think more pylint warnings can be enabled here.

After running this, I quickly checked:
 - all of the tests still pass
 - run-layout-tests and webkit-patch rebaseline still work

[qyearsley, 2016-05-25 22:24:56]

Description was changed from

==========
Run format-webkit on webkitpy code (without string conversion).

This is a follow-up to http://crrev.com/1839193004; the auto-formatting done
by this CL is similar to that done in that CL, except ./format-webkitpy calls
autopep8 with --aggressive.

Specifically:

  ./format-webkitpy --leave-strings-alone --no-backups $(find . -name '*.py' |
grep -v thirdparty)

BUG=598897
==========

to

==========
Run format-webkit on webkitpy code (without string conversion).

This is a follow-up to http://crrev.com/1839193004; the auto-formatting done
by this CL is similar to that done in that CL, except ./format-webkitpy calls
autopep8 with --aggressive.

Specifically:

  ./format-webkitpy --leave-strings-alone --no-backups $(find . -name '*.py' |
grep -v thirdparty)

Also ran the same command on the Python files in Tools/Scripts.

BUG=598897
==========

[qyearsley, 2016-05-26 00:58:52]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-26 01:00:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014063002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014063002/1

[commit-bot: I haz the power, 2016-05-26 04:32:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 04:32:21]

Dry run: This issue passed the CQ dry run.

[commit-bot: I haz the power, 2016-05-26 04:32:27]

Dry run: None

[mithro, 2016-05-27 04:12:07]

On 2016/05/26 at 04:32:27, commit-bot wrote:
> Dry run: None

Two small issues, otherwise LGTM.

How close does this get us to being able to have a presbumit which prevents
adding pep8 issues?

Tim 'mithro' Ansell

[qyearsley, 2016-05-27 16:06:03]

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py
(right):

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py:91:
"""Contains the information for one file in a patch.
Blank line before class docstring is not necessarily required; the
auto-formatter could be changed to not do this if anybody has any opinions here.
https://github.com/hhatto/autopep8/issues/194

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py
(right):

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py:63:
# 'failure_map': { } # Map from letter code to expectation name.
This re-indentation is not intended. Maybe autopep8 wouldn't mess with it if it
were in a docstring.

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
(right):

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:593:
'virtual void determineARIADropEffects(Vector<String>*&, const unsigned long
int*&, const MediaPlayer::Preload, Other<Other2, Other3<P1, P2> >, int);'],
In cases like this, the formatting could be made better by manually breaking up
the string.

[qyearsley, 2016-05-27 16:08:57]

On 2016/05/27 at 04:12:07, tansell wrote:
> On 2016/05/26 at 04:32:27, commit-bot wrote:
> > Dry run: None
> 
> Two small issues, otherwise LGTM.
> 
> How close does this get us to being able to have a presbumit which prevents
adding pep8 issues?
> 
> Tim 'mithro' Ansell

What issues? (We may want to modify webkitpy/formatter/main.py and re-run.)

There are still some pylint warnings that "format-webkitpy" doesn't fix,
including:

anomalous-backslash-in-string
attribute-defined-outside-init
bad-continuation
bare-except
dangerous-default-value
deprecated-lambda
redefined-builtin
relative-import
unused-argument
unused-import
unused-variable

BUT, if people are OK with it, enabling pylint warnings on presubmit could be
done at any time (http://crrev.com/2010173003) -- the presubmit only checks
modified lines, so I don't think it would cause too much trouble to enable that
now.

[Dirk Pranke, 2016-06-01 00:06:48]

this more-or-less lgtm, but that's mostly a rubber stamp and I don't care that
much. Ideally tansell can reply again, but feel free to land after a day or two
if he doesn't.

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py
(right):

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py:91:
"""Contains the information for one file in a patch.
On 2016/05/27 16:06:03, qyearsley wrote:
> Blank line before class docstring is not necessarily required; the
> auto-formatter could be changed to not do this if anybody has any opinions
here.
> https://github.com/hhatto/autopep8/issues/194

I'm not particularly a fan of the blank line.

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py
(right):

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py:63:
# 'failure_map': { } # Map from letter code to expectation name.
On 2016/05/27 16:06:03, qyearsley wrote:
> This re-indentation is not intended. Maybe autopep8 wouldn't mess with it if
it
> were in a docstring.

strange ...

[mithro, 2016-06-01 01:01:42]

lgtm

Dunno why these two comments didn't go out with my initial response.

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py
(right):

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py:91:
'DumpRenderTree_2011-06-13-150723_quadzen.crash'] =
misformatted_mock_crash_report
These two lines probably shouldn't be wrapped. You can append a `# noqa` to the
end of the lines to prevent it.

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py
(right):

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py:48:
#  'builder name' : {
Not sure what is going on in this file, it shouldn't really be modifying these
comments.

[qyearsley, 2016-06-01 21:24:23]

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py
(right):

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py:91:
"""Contains the information for one file in a patch.
On 2016/06/01 at 00:06:47, Dirk Pranke wrote:
> On 2016/05/27 16:06:03, qyearsley wrote:
> > Blank line before class docstring is not necessarily required; the
> > auto-formatter could be changed to not do this if anybody has any opinions
here.
> > https://github.com/hhatto/autopep8/issues/194
> 
> I'm not particularly a fan of the blank line.

Alright -- changed formatter/main.py to not add that blank line.

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py
(right):

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py:91:
'DumpRenderTree_2011-06-13-150723_quadzen.crash'] =
misformatted_mock_crash_report
On 2016/06/01 at 01:01:42, mithro wrote:
> These two lines probably shouldn't be wrapped. You can append a `# noqa` to
the end of the lines to prevent it.

Done.

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py
(right):

https://codereview.chromium.org/2014063002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py:48:
#  'builder name' : {
On 2016/06/01 at 01:01:42, mithro wrote:
> Not sure what is going on in this file, it shouldn't really be modifying these
comments.

Yeah, I'm not sure either. Now put this in a docstring, and autopep8 does not
not modify it anymore.

[qyearsley, 2016-06-01 21:24:28]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-06-01 21:24:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, tansell@chromium.org
Link to the patchset: https://codereview.chromium.org/2014063002/#ps20001
(title: "Responded to comments")

[commit-bot: I haz the power, 2016-06-01 21:25:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014063002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014063002/20001

[commit-bot: I haz the power, 2016-06-01 21:30:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 21:30:23]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[qyearsley, 2016-06-02 00:30:09]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-06-02 00:30:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, tansell@chromium.org
Link to the patchset: https://codereview.chromium.org/2014063002/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2016-06-02 00:31:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014063002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014063002/60001

[commit-bot: I haz the power, 2016-06-02 02:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 02:37:25]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[qyearsley, 2016-06-02 03:26:27]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-06-02 03:27:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014063002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014063002/60001

[commit-bot: I haz the power, 2016-06-02 04:10:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 04:10:27]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[qyearsley, 2016-06-02 15:48:07]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-06-02 15:48:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014063002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014063002/60001

[commit-bot: I haz the power, 2016-06-02 17:11:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-02 17:12:05]

Description was changed from

==========
Run format-webkit on webkitpy code (without string conversion).

This is a follow-up to http://crrev.com/1839193004; the auto-formatting done
by this CL is similar to that done in that CL, except ./format-webkitpy calls
autopep8 with --aggressive.

Specifically:

  ./format-webkitpy --leave-strings-alone --no-backups $(find . -name '*.py' |
grep -v thirdparty)

Also ran the same command on the Python files in Tools/Scripts.

BUG=598897
==========

to

==========
Run format-webkit on webkitpy code (without string conversion).

This is a follow-up to http://crrev.com/1839193004; the auto-formatting done
by this CL is similar to that done in that CL, except ./format-webkitpy calls
autopep8 with --aggressive.

Specifically:

  ./format-webkitpy --leave-strings-alone --no-backups $(find . -name '*.py' |
grep -v thirdparty)

Also ran the same command on the Python files in Tools/Scripts.

BUG=598897

Committed: https://crrev.com/32c236f5f3e81f364347723909d45971eb713400
Cr-Commit-Position: refs/heads/master@{#397453}
==========

[commit-bot: I haz the power, 2016-06-02 17:12:07]

Patchset 4 (id:??) landed as
https://crrev.com/32c236f5f3e81f364347723909d45971eb713400
Cr-Commit-Position: refs/heads/master@{#397453}