third_party/WebKit/Tools/Scripts/webkitpy/common/host.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/host.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/find_files.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/host.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py

index 9eabd44e5dba6d153f00550df31c018131e17a7d..fc74a37893c3cc8f8722d4d6e5e8afe28e50c690 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py

@@ -86,7 +86,7 @@ class Host(SystemHost):

def _engage_awesome_windows_hacks(self):

try:

self.executive.run_command(['git', 'help'])

- except OSError, e:

+ except OSError as e:

try:

self.executive.run_command(['git.bat', 'help'])

# The Win port uses the depot_tools package, which contains a number

@@ -102,7 +102,7 @@ class Host(SystemHost):

_log.debug('Engaging git.bat Windows hack.')

from webkitpy.common.checkout.scm.git import Git

Git.executable_name = 'git.bat'

- except OSError, e:

+ except OSError as e:

_log.debug('Failed to engage git.bat Windows hack.')

def initialize_scm(self, patch_directories=None):