third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/formatter/main.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

index b082338187e0a38a6c9e5455fd31c13d3a490f71..074fcf3926c648162a53d2e56c426805e4bc17fb 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

@@ -92,7 +92,7 @@ class DumpReaderMultipart(DumpReader):

return None

def _check_breakpad_tools_available(self):

- if self._breakpad_tools_available != None:

+ if self._breakpad_tools_available is not None:

return self._breakpad_tools_available

REQUIRED_BREAKPAD_TOOLS = [

@@ -119,7 +119,8 @@ class DumpReaderMultipart(DumpReader):

return self._host.filesystem.join(self._build_dir, "minidump_stackwalk")

def _path_to_generate_breakpad_symbols(self):

- return self._webkit_finder.path_from_chromium_base("components", "crash", "content", "tools", "generate_breakpad_symbols.py")

+ return self._webkit_finder.path_from_chromium_base(

+ "components", "crash", "content", "tools", "generate_breakpad_symbols.py")

def _symbols_dir(self):

return self._host.filesystem.join(self._build_dir, 'content_shell.syms')