third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py

index e0edd9f3a093140fb62e62536e165d86f90c45ce..e75fe78c7ba67bcdcd5495dca03073deffe90952 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py

@@ -87,7 +87,7 @@ def _rebaseline_test(test_file, baseline_target, baseline_move_to, test_config,

actual_result_extensions)

if extensions_to_move.intersection(

- current_baselines.get(baseline_move_to, {}).keys()):

+ current_baselines.get(baseline_move_to, {}).keys()):

log(' Already had baselines in %s, could not move existing '

'%s ones' % (baseline_move_to, baseline_target))

return False

@@ -95,12 +95,12 @@ def _rebaseline_test(test_file, baseline_target, baseline_move_to, test_config,

# Do the actual move.

if extensions_to_move:

if not _move_test_baselines(

- test_file,

- list(extensions_to_move),

- baseline_target,

- baseline_move_to,

- test_config,

- log):

+ test_file,

+ list(extensions_to_move),

+ baseline_target,

+ baseline_move_to,

+ test_config,

+ log):

return False

else:

log(' No current baselines to move')