third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/xml.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/xml.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/style/error_handlers.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (C) 2010 Apple Inc. All rights reserved.	1 # Copyright (C) 2010 Apple Inc. All rights reserved.

2 #	2 #

3 # Redistribution and use in source and binary forms, with or without	3 # Redistribution and use in source and binary forms, with or without

4 # modification, are permitted provided that the following conditions	4 # modification, are permitted provided that the following conditions

5 # are met:	5 # are met:

6 # 1. Redistributions of source code must retain the above copyright	6 # 1. Redistributions of source code must retain the above copyright

7 # notice, this list of conditions and the following disclaimer.	7 # notice, this list of conditions and the following disclaimer.

8 # 2. Redistributions in binary form must reproduce the above copyright	8 # 2. Redistributions in binary form must reproduce the above copyright

9 # notice, this list of conditions and the following disclaimer in the	9 # notice, this list of conditions and the following disclaimer in the

10 # documentation and/or other materials provided with the distribution.	10 # documentation and/or other materials provided with the distribution.

(...skipping 23 matching lines...) Expand all Loading...
34 self._handle_style_error = handle_style_error	34 self._handle_style_error = handle_style_error

35 self._handle_style_error.turn_off_line_filtering()	35 self._handle_style_error.turn_off_line_filtering()

36	36

37 def check(self, lines):	37 def check(self, lines):

38 parser = expat.ParserCreate()	38 parser = expat.ParserCreate()

39 try:	39 try:

40 for line in lines:	40 for line in lines:

41 parser.Parse(line)	41 parser.Parse(line)

42 parser.Parse('\n')	42 parser.Parse('\n')

43 parser.Parse('', True)	43 parser.Parse('', True)

44 except expat.ExpatError, error:	44 except expat.ExpatError as error:

45 self._handle_style_error(error.lineno, 'xml/syntax', 5, expat.ErrorS tring(error.code))	45 self._handle_style_error(error.lineno, 'xml/syntax', 5, expat.ErrorS tring(error.code))

OLD	NEW