third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py

index 15eafe0005e9246b5295ffa644575722c6b48369..33c5409b3b145d527db9950d4a9b7976ac2f170b 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py

@@ -126,14 +126,14 @@ class LayoutTestRunner(object):

if num_workers > 0:

with message_pool.get(self, self._worker_factory, num_workers, self._port.host) as pool:

pool.run(('test_list', shard.name, shard.test_inputs) for shard in self._shards_to_redo)

- except TestRunInterruptedException, e:

+ except TestRunInterruptedException as e:

_log.warning(e.reason)

run_results.interrupted = True

except KeyboardInterrupt:

self._printer.flush()

self._printer.writeln('Interrupted, exiting ...')

run_results.keyboard_interrupted = True

- except Exception, e:

+ except Exception as e:

_log.debug('%s("%s") raised, exiting' % (e.__class__.__name__, str(e)))

raise

finally: