third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commitannouncer.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commitannouncer.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commandtest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (c) 2013 Google Inc. All rights reserved.	1 # Copyright (c) 2013 Google Inc. All rights reserved.

2 #	2 #

3 # Redistribution and use in source and binary forms, with or without	3 # Redistribution and use in source and binary forms, with or without

4 # modification, are permitted provided that the following conditions are	4 # modification, are permitted provided that the following conditions are

5 # met:	5 # met:

6 #	6 #

7 # * Redistributions of source code must retain the above copyright	7 # * Redistributions of source code must retain the above copyright

8 # notice, this list of conditions and the following disclaimer.	8 # notice, this list of conditions and the following disclaimer.

9 # * Redistributions in binary form must reproduce the above	9 # * Redistributions in binary form must reproduce the above

10 # copyright notice, this list of conditions and the following disclaimer	10 # copyright notice, this list of conditions and the following disclaimer

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 def execute(self, options, args, tool):	51 def execute(self, options, args, tool):

52 bot_thread = CommitAnnouncerThread(tool, announce_path, options.irc_pass word)	52 bot_thread = CommitAnnouncerThread(tool, announce_path, options.irc_pass word)

53 bot_thread.start()	53 bot_thread.start()

54 _log.info("Bot started")	54 _log.info("Bot started")

55 try:	55 try:

56 while bot_thread.is_alive():	56 while bot_thread.is_alive():

57 bot_thread.bot.post_new_commits()	57 bot_thread.bot.post_new_commits()

58 time.sleep(update_wait_seconds)	58 time.sleep(update_wait_seconds)

59 except KeyboardInterrupt:	59 except KeyboardInterrupt:

60 _log.error("Terminated by keyboard interrupt")	60 _log.error("Terminated by keyboard interrupt")

61 except Exception, e:	61 except Exception as e:

62 _log.error("Unexpected error:")	62 _log.error("Unexpected error:")

63 _log.error(traceback.format_exc())	63 _log.error(traceback.format_exc())

64	64

65 if bot_thread.is_alive():	65 if bot_thread.is_alive():

66 _log.info("Disconnecting bot")	66 _log.info("Disconnecting bot")

67 bot_thread.stop()	67 bot_thread.stop()

68 else:	68 else:

69 _log.info("Bot offline")	69 _log.info("Bot offline")

70 _log.info("Done")	70 _log.info("Done")

OLD	NEW