Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright (C) 2011 Google Inc. All rights reserved. | 1 # Copyright (C) 2011 Google Inc. All rights reserved. |
| 2 # | 2 # |
| 3 # Redistribution and use in source and binary forms, with or without | 3 # Redistribution and use in source and binary forms, with or without |
| 4 # modification, are permitted provided that the following conditions | 4 # modification, are permitted provided that the following conditions |
| 5 # are met: | 5 # are met: |
| 6 # | 6 # |
| 7 # 1. Redistributions of source code must retain the above copyright | 7 # 1. Redistributions of source code must retain the above copyright |
| 8 # notice, this list of conditions and the following disclaimer. | 8 # notice, this list of conditions and the following disclaimer. |
| 9 # 2. Redistributions in binary form must reproduce the above copyright | 9 # 2. Redistributions in binary form must reproduce the above copyright |
| 10 # notice, this list of conditions and the following disclaimer in the | 10 # notice, this list of conditions and the following disclaimer in the |
| (...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 78 mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree', 2853 0) | 78 mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree', 2853 0) |
| 79 newer_mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree' , 28529) | 79 newer_mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree' , 28529) |
| 80 other_process_mock_crash_report = make_mock_crash_report_darwin('FooProc ess', 28527) | 80 other_process_mock_crash_report = make_mock_crash_report_darwin('FooProc ess', 28527) |
| 81 misformatted_mock_crash_report = 'Junk that should not appear in a crash report' + \ | 81 misformatted_mock_crash_report = 'Junk that should not appear in a crash report' + \ |
| 82 make_mock_crash_report_darwin('DumpRenderTree', 28526)[200:] | 82 make_mock_crash_report_darwin('DumpRenderTree', 28526)[200:] |
| 83 files = {} | 83 files = {} |
| 84 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150718_quadzen.crash'] = older_mock_crash_report | 84 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150718_quadzen.crash'] = older_mock_crash_report |
| 85 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150719_quadzen.crash'] = mock_crash_report | 85 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150719_quadzen.crash'] = mock_crash_report |
| 86 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150720_quadzen.crash'] = newer_mock_crash_report | 86 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150720_quadzen.crash'] = newer_mock_crash_report |
| 87 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150721_quadzen.crash'] = None | 87 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150721_quadzen.crash'] = None |
| 88 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150722_quadzen.crash'] = other_process_mock_crash_report | 88 files['/Users/mock/Library/Logs/DiagnosticReports/' |
| 89 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150723_quadzen.crash'] = misformatted_mock_crash_report | 89 'DumpRenderTree_2011-06-13-150722_quadzen.crash'] = other_process_ mock_crash_report |
| 90 files['/Users/mock/Library/Logs/DiagnosticReports/' | |
| 91 'DumpRenderTree_2011-06-13-150723_quadzen.crash'] = misformatted_m ock_crash_report | |
|
mithro
2016/06/01 01:01:42
These two lines probably shouldn't be wrapped. You
qyearsley
2016/06/01 21:24:22
Done.
| |
| 90 filesystem = MockFileSystem(files) | 92 filesystem = MockFileSystem(files) |
| 91 crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem)) | 93 crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem)) |
| 92 log = crash_logs.find_newest_log("DumpRenderTree") | 94 log = crash_logs.find_newest_log("DumpRenderTree") |
| 93 self.assertMultiLineEqual(log, newer_mock_crash_report) | 95 self.assertMultiLineEqual(log, newer_mock_crash_report) |
| 94 log = crash_logs.find_newest_log("DumpRenderTree", 28529) | 96 log = crash_logs.find_newest_log("DumpRenderTree", 28529) |
| 95 self.assertMultiLineEqual(log, newer_mock_crash_report) | 97 self.assertMultiLineEqual(log, newer_mock_crash_report) |
| 96 log = crash_logs.find_newest_log("DumpRenderTree", 28530) | 98 log = crash_logs.find_newest_log("DumpRenderTree", 28530) |
| 97 self.assertMultiLineEqual(log, mock_crash_report) | 99 self.assertMultiLineEqual(log, mock_crash_report) |
| 98 log = crash_logs.find_newest_log("DumpRenderTree", 28531) | 100 log = crash_logs.find_newest_log("DumpRenderTree", 28531) |
| 99 self.assertIsNone(log) | 101 self.assertIsNone(log) |
| 100 log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0) | 102 log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0) |
| 101 self.assertIsNone(log) | 103 self.assertIsNone(log) |
| 102 | 104 |
| 103 def bad_read(path): | 105 def bad_read(path): |
| 104 raise IOError('IOError: No such file or directory') | 106 raise IOError('IOError: No such file or directory') |
| 105 | 107 |
| 106 def bad_mtime(path): | 108 def bad_mtime(path): |
| 107 raise OSError('OSError: No such file or directory') | 109 raise OSError('OSError: No such file or directory') |
| 108 | 110 |
| 109 filesystem.read_text_file = bad_read | 111 filesystem.read_text_file = bad_read |
| 110 log = crash_logs.find_newest_log("DumpRenderTree", 28531, include_errors =True) | 112 log = crash_logs.find_newest_log("DumpRenderTree", 28531, include_errors =True) |
| 111 self.assertIn('IOError: No such file or directory', log) | 113 self.assertIn('IOError: No such file or directory', log) |
| 112 | 114 |
| 113 filesystem = MockFileSystem(files) | 115 filesystem = MockFileSystem(files) |
| 114 crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem)) | 116 crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem)) |
| 115 filesystem.mtime = bad_mtime | 117 filesystem.mtime = bad_mtime |
| 116 log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0, inclu de_errors=True) | 118 log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0, inclu de_errors=True) |
| 117 self.assertIn('OSError: No such file or directory', log) | 119 self.assertIn('OSError: No such file or directory', log) |
| OLD | NEW |