third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs.py

index b00998d308fc7d057ffa22a1418bc56888b13f17..058308462e90020789b5be18c3f3e4bb8b0f70bc 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs.py

@@ -63,10 +63,10 @@ class CrashLogs(object):

match = first_line_regex.match(f[0:f.find('\n')])

if match and match.group('process_name') == process_name and (pid is None or int(match.group('pid')) == pid):

return errors + f

- except IOError, e:

+ except IOError as e:

if include_errors:

errors += "ERROR: Failed to read '%s': %s\n" % (path, str(e))

- except OSError, e:

+ except OSError as e:

if include_errors:

errors += "ERROR: Failed to read '%s': %s\n" % (path, str(e))