third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

index f7c2d70cc3ef758f1fd90cadb8e81b5adb05eb10..f569cedfc071eec7f27bb5c99f3204c223ca3eff 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

@@ -30,6 +30,7 @@ import copy

import logging

from webkitpy.common.memoized import memoized

+from functools import reduce

_log = logging.getLogger(__name__)

@@ -292,7 +293,8 @@ class BaselineOptimizer(object):

self.new_results_by_directory.append(results_by_directory)

return True

- if self._results_by_port_name(results_by_directory, baseline_name) != self._results_by_port_name(new_results_by_directory, baseline_name):

+ if self._results_by_port_name(results_by_directory, baseline_name) != self._results_by_port_name(

+ new_results_by_directory, baseline_name):

# This really should never happen. Just a sanity check to make sure the script fails in the case of bugs

# instead of committing incorrect baselines.

_log.error(" %s: optimization failed" % basename)