third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

index b4ee4944932bb7ec077c574755ed45342e399a80..96784e5768553a2dadad05c9e3e3d1ead88ea396 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

@@ -121,7 +121,7 @@ class WinPort(base.Port):

# existing entry points to a valid path and has the right command line.

if len(args) == 2 and self._filesystem.exists(args[0]) and args[0].endswith('perl.exe') and args[1] == '-wT':

return True

- except WindowsError, e:

+ except WindowsError as e:

if e.errno != errno.ENOENT:

raise e

# The key simply probably doesn't exist.

@@ -140,7 +140,7 @@ class WinPort(base.Port):

if not self.get_option('disable_breakpad'):

assert not self._crash_service, 'Already running a crash service'

- if self._crash_service_available == None:

+ if self._crash_service_available is None:

self._crash_service_available = self._check_crash_service_available()

if not self._crash_service_available:

return