third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py b/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py

index 127c733f6a7adfa7ee4e69809975480b72ae4972..a1f5bce23f4986366cf56e6a71c934758ccb8ba6 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py

@@ -200,13 +200,14 @@ class PerfTest(object):

return self._metrics[metric_name]

def run_single(self, driver, test_path, time_out_ms, should_run_pixel_test=False):

- return driver.run_test(DriverInput(test_path, time_out_ms, image_hash=None, should_run_pixel_test=should_run_pixel_test, args=[]), stop_when_done=False)

+ return driver.run_test(

+ DriverInput(test_path, time_out_ms, image_hash=None, should_run_pixel_test=should_run_pixel_test, args=[]), stop_when_done=False)

def run_failed(self, output):

if output.error:

_log.error('error: %s\n%s' % (self.test_name(), output.error))

- if output.text == None:

+ if output.text is None:

pass

elif output.timeout:

_log.error('timeout: %s' % self.test_name())