third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

index f2195e4572f04c2f5afcf687911b1547f967b428..c6c2bf1c5396d15fed19347d54002bc5276c7075 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

@@ -172,7 +172,7 @@ class PortTestCase(unittest.TestCase):

test_socket = socket.socket()

test_socket.connect((host, port))

self.fail()

- except IOError, e:

+ except IOError as e:

self.assertTrue(e.errno in (errno.ECONNREFUSED, errno.ECONNRESET))

finally:

test_socket.close()

@@ -182,7 +182,7 @@ class PortTestCase(unittest.TestCase):

try:

test_socket = socket.socket()

test_socket.connect((host, port))

- except IOError, e:

+ except IOError as e:

self.fail('failed to connect to %s:%d' % (host, port))

finally:

test_socket.close()

@@ -231,7 +231,7 @@ class PortTestCase(unittest.TestCase):

exception_raised = False

try:

port.diff_image("EXPECTED", "ACTUAL")

- except ValueError, e:

+ except ValueError as e:

exception_raised = True

self.assertFalse(exception_raised)